Couldn’t test a lot, but I think this is a bug.
Couldn’t test a lot, but I think this is a bug.
If you set a shortcut to run script, and you don’t write any data in the box to pass, the event.getData() returns “”
I remember that in the past it returned null (I have a script that now works different because of this)
]]>
D5 Creation
< ![CDATA[
Yes, it’s seems like a bug.
]]>
< ![CDATA[
Pierre Hébert?
]]>
< ![CDATA[
Sorry, I missed this post! (flood effect?)
I don’t think the bahvior has been modified, but there is a subtle thing here: it will store null if you cancel the dialog (tap outside or hit back) but will store an empty string if you tap on OK. Is this the issue ?
]]>
< ![CDATA[
Pierre Hébert Yes, you’re right. This should be changed. When adding a shortcut to run a script, a user won’t probably click “cancel”.
]]>
< ![CDATA[
Pierre Hébert Uhm… there is no “cancel” button… only “ok” (at least in 10.6.5).
]]>
< ![CDATA[
Pierre Hébert Also this dialog does not show when later choosing “run script” as action for events, only when directly adding a new shortcut to LL Action “run script”.
]]>
< ![CDATA[
Pierre Hébert make sure that when you check the posts you are in the community page, not in the home page of Google+ (sometimes posts are not showed there)
Regarding the topic, as Lutz said no many people will cancel the dialog.
Suggestion: even thought I like this new way of choosing a script, and I will be fine if you leave it, when I suggested it I had in mind a different way. Instead of a full screen list with the scripts what about when you click ‘run a script’ an alert dialog is displayed with:
The title ‘Choose a script’ or whatever
A drop down list with the last selected script already selected.
A checkbox disabled by default with the text ‘pass extra data to the script’
A textbox (that will be enabled/disabled based on the checkbox) where you write the extra data.
This way there is no mistake between null (unchecked checkbox) and “” (checked checkbox and nothing in the textbox)
]]>
< ![CDATA[
TrianguloY I think it’s as it is to be able to create a new script immediately in the editor. However, I agree, it’s annoying to be shown the editor when just attaching existing scripts. Your suggestion sounds good.
]]>
< ![CDATA[
For that reason there is a ‘new script’ in the list.
]]>
< ![CDATA[
One step at a time 😉 The truth is that this intermediate script selection screen was a requirement to select a script, since the new editor default is to open without the drawer, which would have make things really confusing. The goal wasn’t really to improve the process, but was a side effect…
Regarding the dialog cancelation, “cancel” is the Android word when you hit outside of the dialog (or hit back), no matter whether you have a cancel button or not, lol 😉
]]>